Skip to content

Commit

Permalink
playwright: remove flaky check (#28260)
Browse files Browse the repository at this point in the history
This sometimes happens too quickly for us to test.

Fixes: #27585
  • Loading branch information
richvdh authored Oct 21, 2024
1 parent 5e59492 commit 3c8ac6f
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions playwright/e2e/crypto/crypto.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,10 @@ test.describe("Cryptography", function () {
await dialog.getByRole("button", { name: "Continue" }).click();
await copyAndContinue(page);

// When the device is verified, the `Setting up keys` step is skipped
if (!isDeviceVerified) {
const uiaDialogTitle = page.locator(".mx_InteractiveAuthDialog .mx_Dialog_title");
await expect(uiaDialogTitle.getByText("Setting up keys")).toBeVisible();
await expect(uiaDialogTitle.getByText("Setting up keys")).not.toBeVisible();
}
// If the device is unverified, there should be a "Setting up keys" step; however, it
// can be quite quick, and playwright can miss it, so we can't test for it.

// Either way, we end up at a success dialog:
await expect(dialog.getByText("Secure Backup successful")).toBeVisible();
await dialog.getByRole("button", { name: "Done" }).click();
await expect(dialog.getByText("Secure Backup successful")).not.toBeVisible();
Expand Down

0 comments on commit 3c8ac6f

Please sign in to comment.