Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dictation when using the Rich Text Editor. #7752

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

pixlwave
Copy link
Member

Upgrades to the latest version of the RTE package, and adjusts the key commands to fix build errors.

RPReplay_Final1707912011.MP4

@pixlwave pixlwave requested a review from Velin92 February 14, 2024 12:06
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2a6677c) 12.38% compared to head (02f1bac) 12.23%.

Files Patch % Lines
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7752      +/-   ##
===========================================
- Coverage    12.38%   12.23%   -0.16%     
===========================================
  Files         1650     1650              
  Lines       163918   163916       -2     
  Branches     66408    66388      -20     
===========================================
- Hits         20309    20054     -255     
- Misses      142941   143215     +274     
+ Partials       668      647      -21     
Flag Coverage Δ
uitests 55.05% <62.50%> (+0.03%) ⬆️
unittests 6.06% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 1dc609b into develop Feb 14, 2024
8 of 9 checks passed
@pixlwave pixlwave deleted the doug/update-rte branch February 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants