Proper font fallback #111
Merged
Proper font fallback #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
approved these changes
Oct 22, 2024
sandhose
force-pushed
the
quenting/font-fallback
branch
from
35fc608 to
9f4ed7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a random one.
I got too annoyed of seeing a serif font when loading MAS with no cache, so I decided to fix this by providing good fonts fallbacks.
Problem with classic fallbacks, is that the layout will usually not be the same as the one you get with the font you actually want to use.
So, this is using
@capsizecss/coreto generate fine-tuned fallbacks which will use local fonts tweaked to match the metrics of the font you actually want to use.Some comparison so that it makes more sense: (on slow 4G throttling)
Before
before.mov
After
after.mov