Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include functional for win builds #29

Closed

Conversation

cannc4
Copy link
Collaborator

@cannc4 cannc4 commented Oct 18, 2023

I was hitting some errors due to std::functional not being available on Windows.
Specifically this setup:

-- Building for: Visual Studio 17 2022
-- The C compiler identification is MSVC 19.35.3221
-- The CXX compiler identification is MSVC 19.35.32217.1

Seems to be able to build after the includes

@nick-thompson
Copy link
Contributor

Thanks @cannc4! I'm going to take this into the develop branch and cut it with the next patch release

@nick-thompson nick-thompson changed the base branch from main to develop October 26, 2023 12:57
@nick-thompson nick-thompson changed the base branch from develop to main October 26, 2023 12:58
@nick-thompson
Copy link
Contributor

Hm changing the base pulled in some other commits, so instead I picked your change onto develop here: a7cd0c2. Closing here as merged, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants