feedback

elemaudio · Jul 23, 2024 · f12b6a9 · f12b6a9
1 parent 16668c7
commit f12b6a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/runtime/elem/builtins/Core.h b/runtime/elem/builtins/Core.h
@@ -50,14 +50,14 @@ namespace elem
                 if (!val.isNumber())
                     return ReturnCode::InvalidPropertyType();
 
-                fade.setFadeInTimeMs(GraphNode<FloatType>::getSampleRate(), static_cast<float>((js::Number) val));
+                fade.setFadeInTimeMs(GraphNode<FloatType>::getSampleRate(), (js::Number) val);
             }
 
             if (key == "fadeOutMs") {
                 if (!val.isNumber())
                     return ReturnCode::InvalidPropertyType();
 
-                fade.setFadeOutTimeMs(GraphNode<FloatType>::getSampleRate(), static_cast<float>((js::Number) val));
+                fade.setFadeOutTimeMs(GraphNode<FloatType>::getSampleRate(), (js::Number) val);
             }
 
             return GraphNode<FloatType>::setProperty(key, val);

diff --git a/runtime/elem/builtins/helpers/GainFade.h b/runtime/elem/builtins/helpers/GainFade.h
@@ -43,8 +43,9 @@ namespace elem
 
         FloatType operator() (FloatType x) {
             auto const _currentGain = currentGain.load();
-            if (_currentGain == targetGain.load())
-                return (_currentGain * x);
+            auto const _targetGain = targetGain.load();
+            if (fpEqual(_currentGain, _targetGain))
+                return (_targetGain * x);
 
             auto y = x * _currentGain;
             currentGain.store(std::clamp(_currentGain + step.load(), FloatType(0), FloatType(1)));
@@ -54,9 +55,10 @@ namespace elem
 
         void process (const FloatType* input, FloatType* output, int numSamples) {
             auto const _currentGain = currentGain.load();
-            if (_currentGain == targetGain.load()) {
+            auto const _targetGain = targetGain.load();
+            if (_currentGain == _targetGain) {
                 for (int i = 0; i < numSamples; ++i) {
-                    output[i] = input[i] * _currentGain;
+                    output[i] = input[i] * _targetGain;
                 }
                 return;
             }