Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] new split index implementation #862

Merged
merged 12 commits into from
Jul 13, 2023

Conversation

toxa81
Copy link
Collaborator

@toxa81 toxa81 commented Jul 12, 2023

No description provided.

@simonpintarelli
Copy link
Collaborator

I've changed operator* to return an unnamed struct containing Index::global i, Index::local li, and removed the global index from the class variables. i was not updated when calling operator++, and without knowing how the class is implemented, one might use the following code:

for(auto it = begin(spl_index); it != end(spl_index); ++it) {
   (void) it.i; // Global index is accessible, but not updated
   (void) *(it.i).i; // Global index is set only in operator*
}

@toxa81 toxa81 marked this pull request as ready for review July 13, 2023 11:23
@toxa81 toxa81 self-assigned this Jul 13, 2023
@toxa81 toxa81 added the feature label Jul 13, 2023
Copy link
Collaborator

@simonpintarelli simonpintarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonpintarelli simonpintarelli merged commit 687ccaa into develop Jul 13, 2023
3 checks passed
@toxa81 toxa81 deleted the feature/new-split-index-impl-v2-rebase branch July 25, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants