Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split index proposal #861

Closed
wants to merge 15 commits into from

Conversation

simonpintarelli
Copy link
Collaborator

@simonpintarelli simonpintarelli commented Jul 12, 2023

Proposal for changes in #850:

Change operator* to:

    inline auto operator*()
    {
        return std::make_pair(idx_->global_index(this->li), this->li);
    }

And then use for (auto [i, li] : spl_index) { }. Structured bindings is a c++17 feature, but it seems to work when using c++14 standard too (adding -Wno-c++17-extensions to suppress noise)

@simonpintarelli simonpintarelli marked this pull request as draft July 12, 2023 19:59
@toxa81
Copy link
Collaborator

toxa81 commented Jul 12, 2023

I'm working on rebase, should be ready by tomorrow

@simonpintarelli simonpintarelli force-pushed the feature/split-index-proposal branch 2 times, most recently from b91e7ba to 3ca3e24 Compare July 13, 2023 07:39
@simonpintarelli
Copy link
Collaborator Author

Unfortunately the structured bindings don't work together with openmp/clang: https://godbolt.org/z/GaM374fe4

Locally clang is even crashing when the index is used inside the openmp region, which occurs several times.

@toxa81 toxa81 deleted the feature/split-index-proposal branch July 25, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants