Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add theme data source for devtools (32-x-y) #44098

Open
wants to merge 5 commits into
base: 32-x-y
Choose a base branch
from
Open

fix: add theme data source for devtools (32-x-y) #44098

wants to merge 5 commits into from
+182 −2

Conversation

cucbin
Copy link
Contributor

@cucbin cucbin commented Oct 2, 2024

Description of Change

Fix #43367

Checklist

Release Notes

Notes: Fix theme data source not found for devtools.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2024
@MarshallOfSound MarshallOfSound added backport-check-skip Skip trop's backport validity checking target/31-x-y PR should also be added to the "31-x-y" branch. labels Oct 3, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 3, 2024
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Oct 3, 2024
@cucbin
Copy link
Contributor Author

cucbin commented Oct 3, 2024

@MarshallOfSound @codebytere
Please help review the PR.
I would like to target the branch with main, but there's a line of code conflict, I will submit a new PR and target to main branch after review. Now set the target branch as 32-x-y temporarily.

@MarshallOfSound MarshallOfSound removed backport-check-skip Skip trop's backport validity checking target/31-x-y PR should also be added to the "31-x-y" branch. labels Oct 3, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 3, 2024
@cucbin cucbin changed the title fix: add theme data source for devtools fix: add theme data source for devtools (32-x-y) Oct 4, 2024
@cucbin cucbin marked this pull request as ready for review October 4, 2024 06:48
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 4, 2024
@bpasero
Copy link
Contributor

bpasero commented Oct 12, 2024 •
edited
Loading

@codebytere as someone that suffers from this (cannot stand light themes anymore and we recently switched to Electron 32 in VS Code) I would love a fix here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cucbin @bpasero @MarshallOfSound