New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused argument in cmake custom project commands #655

Open

Alloyed wants to merge 1 commit into electro-smith:master from Alloyed:patch-3

Alloyed commented Nov 11, 2024

per https://cmake.org/cmake/help/latest/command/add_custom_command.html#build-events, add_custom_command() with a target doesn't actually take a dependency list, but relies on the dependency list of the target you passed in. In this case because the dependency was the target I think this is semantically equivalent?

caught by https://cmake.org/cmake/help/latest/policy/CMP0175.html#policy:CMP0175


          Remove unused argument in cmake custom project commands

5cb9a35

per https://cmake.org/cmake/help/latest/command/add_custom_command.html#build-events, add_custom_command() with a target doesn't actually take a dependency list, but relies on the dependency list of the target you passed in. In this case because the dependency _was_ the target I think this is semantically equivalent?

caught by https://cmake.org/cmake/help/latest/policy/CMP0175.html#policy:CMP0175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet