chore(client): Add missing optional flag for peer dpeendencies #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfstef
added a commit
that referenced
this pull request
Apr 29, 2024
…#1207) We had an issue with some peer deps not being marked as optional that started causing the npm install to fail (see #1205). Despite that because the starter cli does not return a non zero exit code if it fails at the dep installation phase, some tests were passing - I've modified them to check explicitly that the dep installation error is not shown. Until we upgrade the electric-sql package with the optional peer dep flag, I've added the `--legacy-peer-deps` to `npm install` calls to work around this issue. I will roll this back immediately after release after confirming that the individual examples work correctly as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds peer dependency optional flags that are missing (also reordered to match peer dep order).
Relevant PR: #1187