Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DateTime type from chrono #2

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Expose DateTime type from chrono #2

merged 3 commits into from
Mar 25, 2024

Conversation

hongquan
Copy link
Contributor

Some methods on NaiveDateTime are deprecated and replaced with DateTime. So we need to expose DateTime to let library user use it.

@hongquan
Expose DateTime type from chrono
3c7981f 
Some methods on NaiveDateTime are deprecated and replaced with DateTime.
eldruin
eldruin reviewed Mar 21, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thank you!
Could you add an entry to the changelog about this?

@hongquan
Copy link
Contributor Author

Hi, I added changelog entry.

eldruin
eldruin reviewed Mar 22, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
eldruin
eldruin approved these changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@eldruin eldruin merged commit 1ff7381 into eldruin:master Mar 25, 2024
20 checks passed
@eldruin
Copy link
Owner

eldruin commented Mar 25, 2024

For the record, I have released this in version 0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongquan @eldruin