feat: implement footer #12
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -20,6 +20,7 @@ | |||
| "dependencies": { | |||
| "@emotion/react": "^11.10.5", | |||
| "@emotion/styled": "^11.10.5", | |||
| "@microsoft/eslint-formatter-sarif": "2.1.7", | |||
There was a problem hiding this comment.
Why are we adding this package?
There was a problem hiding this comment.
i thought it will fix the error, maybe i should just remove them
| @@ -51,7 +52,7 @@ | |||
| "@vitest/coverage-c8": "^0.25.3", | |||
| "@vitest/ui": "^0.25.3", | |||
| "babel-plugin-react-require": "^3.1.3", | |||
| "eslint": "^8.27.0", | |||
| "eslint": "8.10.0", | |||
There was a problem hiding this comment.
And it seems you downgraded eslint?
There was a problem hiding this comment.
i followed the error prompt when i made the PR, i thought that was the reason i was getting the error
There was a problem hiding this comment.
Let's revert this.. Ideally, we shouldn't make changes to the linters/formatters in a feature branch
There was a problem hiding this comment.
Alright, will do that
| AccordionSummary, | ||
| AccordionDetails, | ||
| Typography, | ||
| Accordion, |
There was a problem hiding this comment.
It would seem we now have a tabs, space swap in this PR
There was a problem hiding this comment.
i don't understand
| @@ -1,67 +1,67 @@ | |||
| import { FC } from "react"; | |||
| import { AppBar, IconButton, Stack, styled, Toolbar } from "@mui/material"; | |||
| import { Link } from "/src/components/common"; | |||
| import { Link } from "../../../components/common"; | |||
There was a problem hiding this comment.
Why are we not using absolute import here though?
There was a problem hiding this comment.
i am not sure i made those changes
There was a problem hiding this comment.
" pnpm install [email protected]
pnpm install @microsoft/[email protected]"
these are the commands that i ran
No description provided.