Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic SPF support #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

basic SPF support #50

wants to merge 1 commit into from

Conversation

theguly
Copy link

@theguly theguly commented Jan 31, 2018

No description provided.

kitterma
kitterma reviewed Jul 8, 2023
View reviewed changes
Copy link

@kitterma kitterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 622, there should be a space after spf1, i.e. "v=spf1 ". The current code would match (for example) v=spf11, which is not correct.

@theguly
Copy link
Author

theguly commented Jul 10, 2023

i see that the main code is changed a lot since my PR, if you are interested in accepting the PR in a reasonable time i can close this one and create a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitterma kitterma kitterma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theguly @kitterma