Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the LSP code to a dedicated shard #56

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Extract the LSP code to a dedicated shard #56

merged 1 commit into from
Dec 5, 2022

Conversation

elbywan
Copy link
Owner

@elbywan elbywan commented Dec 5, 2022

Scope

  • Extracted the LSP part out of the crystalline repo and moved to a dedicated repo/shard: elbywan/crystal-lsp
  • Moved some files of the src/crystalline/base directory and to the root /src/crystalline folder to make things a bit more idiomatic

Related issue: #54

@elbywan elbywan changed the title extract the LSP part to a dedicated shard Extract the LSP code to a dedicated shard Dec 5, 2022
@elbywan elbywan mentioned this pull request Dec 5, 2022
Closed
asterite
asterite approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

@elbywan elbywan merged commit dbf59f9 into master Dec 5, 2022
@elbywan elbywan deleted the extract-lsp branch December 5, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elbywan @asterite