bug in ungroup (fix for dplyr 1.0.0)

elbersb · Apr 2, 2020 · 3386f98 · 3386f98
1 parent dfc7089
commit 3386f98
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -3,6 +3,7 @@
 - autogenerate documentation
 - data argument now has same name as in tidyr/dplyr (#43)
 - fixes #42
+- fixes "ungroup" bug in tests (found by revdep check for dplyr 1.0.0)
 
 # 1.0.0
 

diff --git a/tests/testthat/test_group_by.R b/tests/testthat/test_group_by.R
@@ -36,16 +36,16 @@ test_that("group_by: argument order", {
 
 test_that("ungroup", {
     expect_message({
-        out <- tidylog::ungroup(mtcars, mpg)
+        out <- tidylog::ungroup(mtcars)
     })
     expect_equal(dplyr::is.grouped_df(out), FALSE)
 
     expect_silent({
-        out <- dplyr::ungroup(mtcars, mpg)
+        out <- dplyr::ungroup(mtcars)
     })
     expect_silent({
         options("tidylog.display" = list())  # turn off
-        out <- tidylog::ungroup(mtcars, mpg)
+        out <- tidylog::ungroup(mtcars)
     })
     options("tidylog.display" = NULL)  # turn on
 })