Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Removed styled components dependency #709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rostyk-kanafotskyy
Copy link
Collaborator

@rostyk-kanafotskyy rostyk-kanafotskyy commented May 15, 2020

Description:

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@rostyk-kanafotskyy rostyk-kanafotskyy self-assigned this May 15, 2020
@rostyk-kanafotskyy rostyk-kanafotskyy changed the title Removed styled components dependency [WIP]Removed styled components dependency May 15, 2020
@rostyk-kanafotskyy
Copy link
Collaborator Author

rostyk-kanafotskyy commented May 15, 2020

@shaunmaharaj @aChanEP Seems like it needs styled-components lib to work 😒
LucasBassetti/react-simple-chatbot#157

@shaunmaharaj
Copy link
Contributor

@aChanEP @rostyk-kanafotskyy Are we trying to remove styled-components to reduce the bundle size? Is code-splitting not enough for the chatbot component?

@aChanEP
Copy link
Contributor

aChanEP commented May 15, 2020

@aChanEP @rostyk-kanafotskyy Are we trying to remove styled-components to reduce the bundle size? Is code-splitting not enough for the chatbot component?

Yes styled components gets bundled along with the chatbot. So removing it would make the bundle size smaller. I don't believe the initial load times would suffer because we've code split it so that it is downloaded asynchronously, but it will hinder how quickly the chatbot is able to be interacted with.

@aChanEP
Copy link
Contributor

aChanEP commented May 15, 2020

@shaunmaharaj @aChanEP Seems like it needs styled-components lib to work 😒
LucasBassetti/react-simple-chatbot#157

All good! atleast now we know that we can't optimize here! I hope they make a fix. Thanks for looking into this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants