-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feature/bloomreach search results page WIP - DO NOT MERGE #428
Open
aChanEP
wants to merge
87
commits into
master
Choose a base branch
from
feature/bloomreach-search-results-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suggestions had populated once.
… once suggestionlistelement had already been populated
shaunmaharaj
changed the title
Feature/bloomreach search results page WIP - DO NOT MERGE
[WIP] Feature/bloomreach search results page WIP - DO NOT MERGE
Sep 25, 2019
aChanEP
force-pushed
the
feature/bloomreach-search-results-page
branch
from
September 25, 2019 22:09
50c1eb7
to
258acd4
Compare
5 tasks
* Able to get mlt products showing up in products display page * use async await pattern * Adjust the name of mlt function * get rid of prop types * fix typescript errors * Move state and props into new file * Able to place bloomreach product recommendations into storybook * Add product recommendation configs * add a new line * adjust files to use new configurations properly * Change the naming of the component * change the padding of the title * Fix the linking to product recommendations * revert settings to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements bloomreach search. Once bloomreach is enabled in ep.config.json the search bar presented will do a keyword search on an endpoint described here:
https://help.bloomreach.com/display/BRINT/Product+search+API
.The search results page will be similar in UI to the original search results with two differences:
Bloomreach modules will now each have their own d.ts files outlining their types. No types will be found in the .tsx files. (should refactor all modules to follow this pattern as it is cleaner).
The configurations have been refactored in this PR so the bloomreach autosuggestions component will also need to be re-tested.
Linting:
Component Updates:
Tests:
e2e
)WIP -- Change the bloomreach settings here...
Documentation: