Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/bloomreach search results page WIP - DO NOT MERGE #428

Open
wants to merge 87 commits into
base: master
Choose a base branch
from

Conversation

aChanEP
Copy link
Contributor

@aChanEP aChanEP commented Sep 24, 2019

Description:

This PR implements bloomreach search. Once bloomreach is enabled in ep.config.json the search bar presented will do a keyword search on an endpoint described here: https://help.bloomreach.com/display/BRINT/Product+search+API.

The search results page will be similar in UI to the original search results with two differences:

  1. The facets are collapsible.
  2. The facets will contain the number of results that a particular facet will filter.

Bloomreach modules will now each have their own d.ts files outlining their types. No types will be found in the .tsx files. (should refactor all modules to follow this pattern as it is cleaner).

The configurations have been refactored in this PR so the bloomreach autosuggestions component will also need to be re-tested.

Linting:

  • No linting errors

Component Updates:

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  1. Paste these BR settings:
    WIP -- Change the bloomreach settings here...
"bloomreach": {
    "env": {
      "baseUri": "http://core.dxpapi.com/api/v1/core/?",
      "accountId": "account_id=6226",
      "authKey": "auth_key=fcao6uq86z58xup0",
      "domainKey": "domain_key=elastic_path",
      "requestId": "request_id=1239723156472",
      "brUID2":"_br_uid_2=uid%3D8030319374785%3Av%3D11.8%3Ats%3D1536857546532%3Ahc%3D111",
      "url": "url=www.bloomique.com",
      "refurl": "ref_url=www.bloomique.com"
    },
    "keywordSearch": {
      "enable": false,
      "requestType": "request_type=search",
      "rows": "rows=10",
      "start": "start=0",
      "facetLimit": "facet.limit=20",
      "fl": "fl=pid%2Ctitle%2Cbrand%2Cprice%2Csale_price%2Cpromotions%2Cthumb_image%2Csku_thumb_images%2Csku_swatch_images%2Csku_color_group%2Curl%2Cprice_range%2Csale_price_range%2Cdescription",
      "searchType": "search_type=keyword"
    },
    "suggestions": {
      "enable": false,
      "baseUri": "http://suggest.dxpapi.com/api/v1/suggest/?",
      "requestType": "request_type=suggest"
    }
  },
  1. Test the keyword search
  2. Test the facet filtering
  3. Start up storybook and notice that rudimentary stories have been placed in

Documentation:

  • Requires documentation updates

… once suggestionlistelement had already been populated
@shaunmaharaj shaunmaharaj changed the title Feature/bloomreach search results page WIP - DO NOT MERGE [WIP] Feature/bloomreach search results page WIP - DO NOT MERGE Sep 25, 2019
@aChanEP aChanEP force-pushed the feature/bloomreach-search-results-page branch from 50c1eb7 to 258acd4 Compare September 25, 2019 22:09
@aChanEP aChanEP mentioned this pull request Sep 30, 2019
5 tasks
aChanEP and others added 5 commits October 1, 2019 11:14
* Able to get mlt products showing up in products display page

* use async await pattern

* Adjust the name of mlt function

* get rid of prop types

* fix typescript errors

* Move state and props into new file

* Able to place bloomreach product recommendations into storybook

* Add product recommendation configs

* add a new line

* adjust files to use new configurations properly

* Change the naming of the component

* change the padding of the title

* Fix the linking to product recommendations

* revert settings to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant