Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New endpoint rules #6100
base: main
Are you sure you want to change the base?
New endpoint rules #6100
Changes from all commits
03bdfc8
2063a1e
bac7f22
bc47e7a
1155e67
ba4373a
067e4f2
55483ea
537e060
9459aa9
29e9b3d
82fe237
14a3e19
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the following rules need to reference prebuilt rule docs, similar to how to provide a link to the Elastic Defend rule docs? (Same question for this section in the Serverless docs.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably eventually, though we might be able to publish an MVP of this page without linking to prebuilt rule docs for now. Getting those prebuilt rule docs might be out of scope for this, and something that TRADE team handles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the links after the rules are published. The docs creation for prebuilt rules is managed by TRADE and those will be added automatically during the rules release process. I think linking them would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Created an enhancement request to add those links once the prebuilt rule docs are published.