Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Serverless][8.16] Notes docs (backport #6006) #6074

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 6, 2024

Contributes to #5441

ESS:

Serverless: (Same changes as detailed above)

* First draft

* First draft

* Updates titles

* Fixes toc and introduces images

* Fixes serverless toc

* Adds missing image

* Typo

* Adds more images and content

* Removes kib ref

* Removed extra kib ref

* Adjusted image name

* Completed ref link

* Adds ref to adv setting

* Removed unnecessary ref

* Missing s

* More minor adjustments

* first draft of flyout changes

* Fix image size

* Moves image over even more

* Update docs/events/add-manage-notes.asciidoc

* Incorporates dev input - ESS

* Serverless changes

* removed extra space

* fixes serverless doc bugs

* One more small fix

* Missing s

* Adds missing image

* Update docs/events/add-manage-notes.asciidoc

* Revision round two

* Added image ext

* Adds nav instructions

* Fixes styling

* Removed extra s

* Removed tab

* Removing asset criticality adv setting again

* Removes comment for now

* Update docs/events/add-manage-notes.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/events/add-manage-notes.asciidoc

* Adds icon names to Serverless docs

* update serverless asciidoc file instead of mdx file

* trigger checks

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit 264ac5e)

# Conflicts:
#	docs/serverless/alerts/alerts-ui-manage.asciidoc
#	docs/serverless/alerts/view-alert-details.asciidoc
#	docs/serverless/index.asciidoc
#	docs/serverless/investigate/timelines-ui.asciidoc
#	docs/serverless/settings/advanced-settings.asciidoc
@mergify mergify bot requested a review from a team as a code owner November 6, 2024 22:05
Copy link
Contributor Author

mergify bot commented Nov 6, 2024

Cherry-pick of 264ac5e has failed:

On branch mergify/bp/8.x/pr-6006
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 264ac5e6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/detections/alerts-ui-manage.asciidoc
	modified:   docs/detections/alerts-view-details.asciidoc
	new file:   docs/detections/images/add-note-icon.png
	new file:   docs/detections/images/notes-tab-lp.png
	new file:   docs/detections/notes-page-timeline-details.png
	new file:   docs/events/add-manage-notes.asciidoc
	new file:   docs/events/images/add-note-icon.png
	new file:   docs/events/images/create-note-icon.png
	new file:   docs/events/images/new-note-alert-event.png
	new file:   docs/events/images/new-note-timeline-tab.png
	new file:   docs/events/images/notes-management-page.png
	new file:   docs/events/images/notes-page-document-details.png
	new file:   docs/events/images/notes-page-timeline-details.png
	modified:   docs/events/investigations-index.asciidoc
	modified:   docs/events/timeline-ui-overview.asciidoc
	modified:   docs/getting-started/advanced-setting.asciidoc
	new file:   docs/serverless/images/icons/timelineWithArrow.svg
	new file:   docs/serverless/images/notes/-notes-management-page.png
	new file:   docs/serverless/images/notes/-notes-new-note-alert-event.png
	new file:   docs/serverless/images/notes/-notes-new-note-timeline-tab.png
	new file:   docs/serverless/images/view-alert-details/-detections-notes-tab-lp.png
	new file:   docs/serverless/investigate/add-manage-notes.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/serverless/alerts/alerts-ui-manage.asciidoc
	deleted by us:   docs/serverless/alerts/view-alert-details.asciidoc
	deleted by us:   docs/serverless/index.asciidoc
	deleted by us:   docs/serverless/investigate/timelines-ui.asciidoc
	deleted by us:   docs/serverless/settings/advanced-settings.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

github-actions bot commented Nov 6, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon
Copy link
Contributor

run docs-build

@nastasha-solomon nastasha-solomon merged commit 2523bd2 into 8.x Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant