Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][8.15 & Serverless] Alert suppression for ES|QL and ML rules #5568

Merged
merged 13 commits into from
Jul 31, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 17, 2024

Fixes #5516 and #5517

ESS previews

Serverless preview
(Same updates as ESS docs, minus API doc updates)

@nastasha-solomon nastasha-solomon added Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels Jul 17, 2024
@nastasha-solomon nastasha-solomon self-assigned this Jul 17, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Jul 17, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review July 17, 2024 02:54
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner July 17, 2024 02:54
@vitaliidm vitaliidm requested a review from rylnd July 17, 2024 08:58
docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/serverless/alerts/alert-suppression.mdx Outdated Show resolved Hide resolved
vitaliidm
vitaliidm previously approved these changes Jul 18, 2024
rylnd
rylnd previously approved these changes Jul 18, 2024
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I offered one suggestion about the phrasing on an ML explanation, but I think it's clear as is, too.

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit suggestion, otherwise looks good!

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jul 22, 2024

Tentatively updating this PR's publication date to next Tuesday (July 30) after discussion with dev this morning.

cc: @vitaliidm @rylnd

@nastasha-solomon
Copy link
Contributor Author

Verified that suppression is available in the UI for Serverless (huzzah!), so merging this PR now!

@nastasha-solomon nastasha-solomon merged commit 506ad4d into main Jul 31, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
…#5568)

* First draft

* More changes

* Fixing styles

* Fixed attribute

* Style update

* Vitalii's input

* ML rule update

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Ryland Herrick <[email protected]>

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/alerts/alert-suppression.mdx

---------

Co-authored-by: Ryland Herrick <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 506ad4d)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx
nastasha-solomon added a commit that referenced this pull request Jul 31, 2024
…L rules (backport #5568) (#5633)

* [Request][8.15 & Serverless] Alert suppression for ES|QL and ML rules (#5568)

* First draft

* More changes

* Fixing styles

* Fixed attribute

* Style update

* Vitalii's input

* ML rule update

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Ryland Herrick <[email protected]>

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/alerts/alert-suppression.mdx

---------

Co-authored-by: Ryland Herrick <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 506ad4d)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 6, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request][8.15 & Serverless] Alert suppression for ES|QL rules
5 participants