Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates "AI for security" section #5443

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Creates "AI for security" section #5443

merged 4 commits into from
Jun 24, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Jun 17, 2024

Fixes #5442

This PR touched a lot of files, but most of the changes in the diff are due to updated folder/section names ("AI Assistant" became "AI for security").

Preview: AI for Security

@benironside benironside added Team: GenAI Generative AI team v8.14.0 labels Jun 17, 2024
@benironside benironside self-assigned this Jun 17, 2024
@benironside benironside requested a review from a team as a code owner June 17, 2024 19:07
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@benironside benironside requested a review from Charelzard June 18, 2024 04:57
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to consider, otherwise looks good!

docs/AI-for-security/ai-use-cases.asciidoc Outdated Show resolved Hide resolved
docs/AI-for-security/ai-use-cases.asciidoc Outdated Show resolved Hide resolved
docs/AI-for-security/ai-for-security.asciidoc Outdated Show resolved Hide resolved
include::azure-openai-setup.asciidoc[leveloffset=+2]
include::connect-to-openai.asciidoc[leveloffset=+2]
include::connect-to-bedrock.asciidoc[leveloffset=+2]

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit, but for consistency, it would be nice to have the child pages under the set up connectors section
listed in the same order in the left nav and on the page itself. Same goes for the pages in the use cases section.

image

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benironside benironside merged commit d32f517 into main Jun 24, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jun 24, 2024
* first test of new org

* fixes build error

* updates landing pages

* incorporates Nat's review

(cherry picked from commit d32f517)
benironside added a commit that referenced this pull request Jun 24, 2024
* first test of new org

* fixes build error

* updates landing pages

* incorporates Nat's review

(cherry picked from commit d32f517)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: GenAI Generative AI team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Create new AI section containing Attack Discovery and AI Assistant guides
2 participants