Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] Adds a video demo to the AD docs (backport #5362) #5363

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 10, 2024

Fixes #5336 by adding a video demo to the AD docs as requested by James S. The video gives an overview of how AD works and shows it in action. I added it at the top of the page. This update affects both ESS and serverless docs.

Also fixes #5361 by making a minor change to how we discuss AD's 24-hour lookback window for alerts.

Preview: ESS, Serverless


This is an automatic backport of pull request #5362 done by Mergify.

* Adds a video to the AD doc

* Adds fix for 5631

(cherry picked from commit ea8158c)

# Conflicts:
#	docs/serverless/attack-discovery/attack-discovery.mdx
@mergify mergify bot requested a review from a team as a code owner June 10, 2024 21:28
Copy link
Contributor Author

mergify bot commented Jun 10, 2024

Cherry-pick of ea8158c has failed:

On branch mergify/bp/8.14/pr-5362
Your branch is up to date with 'origin/8.14'.

You are currently cherry-picking commit ea8158c0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/attack-discovery/attack-discovery.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/serverless/attack-discovery/attack-discovery.mdx

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@benironside
Copy link
Contributor

run docs-build

@benironside benironside merged commit e95a049 into 8.14 Jun 10, 2024
3 checks passed
@mergify mergify bot deleted the mergify/bp/8.14/pr-5362 branch June 10, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant