Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LLM performance matrix doc to ESS & serverless #5286

Merged
merged 16 commits into from
Jun 3, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented May 29, 2024

Fixes #5238 by adding a new page with a table describing how different large language models perform on various tasks within Elastic Security.

Preview: LLM performance matrix (Serverless)
LLM performance matrix (ESS)

@benironside benironside self-assigned this May 29, 2024
@benironside benironside requested a review from a team as a code owner May 29, 2024 23:19
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented May 29, 2024

🚀 Built co-preview-docs successfully!

Issues? Visit #next-docs in Slack

@joepeeples
Copy link
Contributor

joepeeples commented May 31, 2024

For some reason, the classic version duplicates the table:

image

But I also see that the preview is currently re-building, so maybe it's already been fixed?

UPDATE: Looks like it was just a preview rebuild thing, it's no longer duplicated. 😅

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean table! I kinda think the header row with Feature | Model isn't necessary and adds a bit of clutter, but I don't know if AsciiDoc and Markdown syntax will allow tables with no header row.

docs/assistant/llm-performance-matrix.asciidoc Outdated Show resolved Hide resolved
docs/assistant/llm-performance-matrix.asciidoc Outdated Show resolved Hide resolved
docs/assistant/llm-performance-matrix.asciidoc Outdated Show resolved Hide resolved
docs/serverless/assistant/llm-performance-matrix.mdx Outdated Show resolved Hide resolved
docs/serverless/assistant/llm-performance-matrix.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, otherwise LGTM!

docs/assistant/llm-performance-matrix.asciidoc Outdated Show resolved Hide resolved
docs/serverless/assistant/llm-performance-matrix.mdx Outdated Show resolved Hide resolved
@benironside benironside merged commit adb07fa into main Jun 3, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jun 3, 2024
* Adds LLM performance matrix doc to ESS & serverless

* experimenting with matrix formatting

* uses alternative matrix formatting

* updates matrix format, adds alternative version

* uses updated table format

* updates ESS version of table

* fixes table

* removes outdated table formatting

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit adb07fa)

# Conflicts:
#	docs/serverless/serverless-security.docnav.json
mergify bot pushed a commit that referenced this pull request Jun 3, 2024
* Adds LLM performance matrix doc to ESS & serverless

* experimenting with matrix formatting

* uses alternative matrix formatting

* updates matrix format, adds alternative version

* uses updated table format

* updates ESS version of table

* fixes table

* removes outdated table formatting

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit adb07fa)

# Conflicts:
#	docs/serverless/serverless-security.docnav.json
benironside added a commit that referenced this pull request Jun 3, 2024
* Adds LLM performance matrix doc to ESS & serverless

* experimenting with matrix formatting

* uses alternative matrix formatting

* updates matrix format, adds alternative version

* uses updated table format

* updates ESS version of table

* fixes table

* removes outdated table formatting

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit adb07fa)

# Conflicts:
#	docs/serverless/serverless-security.docnav.json

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
benironside added a commit that referenced this pull request Jun 3, 2024
…5286) (#5295)

* Adds LLM performance matrix doc to ESS & serverless (#5286)

* Adds LLM performance matrix doc to ESS & serverless

* experimenting with matrix formatting

* uses alternative matrix formatting

* updates matrix format, adds alternative version

* uses updated table format

* updates ESS version of table

* fixes table

* removes outdated table formatting

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/serverless/assistant/llm-performance-matrix.mdx

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/llm-performance-matrix.asciidoc

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit adb07fa)

# Conflicts:
#	docs/serverless/serverless-security.docnav.json

* remove serverless pages from backport branch

* fixes build

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add a page showing model recommendation matric
4 participants