Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][ESS] Update ES|QL rule type metadata operator syntax #5167

Merged
merged 5 commits into from
May 14, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 6, 2024

Contributes to #5150

Preview:

Serverless docs updated in https://github.com/elastic/staging-serverless-security-docs/pull/340

@nastasha-solomon nastasha-solomon added Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.14.0 Feature: ES|QL labels May 6, 2024
@nastasha-solomon nastasha-solomon self-assigned this May 6, 2024
Copy link

github-actions bot commented May 6, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon requested a review from vitaliidm May 6, 2024 21:20
@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 6, 2024 21:42
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner May 6, 2024 21:42
benironside
benironside previously approved these changes May 6, 2024
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vitaliidm
Copy link
Contributor

Sorry, @benironside, I pushed changes in 9ca2d58 and it automatically dismissed your approval

vitaliidm
vitaliidm previously approved these changes May 7, 2024
docs/detections/rules-ui-create.asciidoc Show resolved Hide resolved
@nastasha-solomon
Copy link
Contributor Author

Using this PR to commit edits that @natasha-moore-elastic suggested in https://github.com/elastic/staging-serverless-security-docs/pull/340.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit ff26101 into main May 14, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 14, 2024
* First draft

* update metadata for API create

* Nat's edits

---------

Co-authored-by: Vitalii Dmyterko <[email protected]>
(cherry picked from commit ff26101)
@nastasha-solomon nastasha-solomon deleted the issue-5150-esql-metadata-syntax-fix branch May 14, 2024 20:32
nastasha-solomon added a commit that referenced this pull request May 14, 2024
… (backport #5167) (#5211)

* First draft

* update metadata for API create

* Nat's edits

---------

Co-authored-by: Vitalii Dmyterko <[email protected]>
(cherry picked from commit ff26101)

Co-authored-by: Nastasha Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: ES|QL Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants