-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates new page detailing Bedrock connector setup #5148
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @benironside? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few small line edits. Also, it'd help to give users a bit more context and explanation of what they're doing overall, and in each subsection. I think these steps are clear enough for users to follow, but we could tell them more about what they're doing, and why.
If Amazon changes their UI in the future (and of course they will), then our users will be better able to adjust if we equip them with a good understanding of broadly what they need to do. If they're just blindly following steps, it'll be harder for them to adjust.
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments I added, everything looks good. Please be sure to include the videos in each respective section. I like how you went the route to add the connectors vs doing it in the ai assistant to give a more standardized approach. We can use this in the other docs going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The added bits nicely guide the reader through this multi-step process.
* Creates new page detailing Bedrock connector setup * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * adds information about provisioned throughput * sentence edits * incorporates Charles' review * adds context to each section * adds video embeds * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * minor format fix * update heading * Update docs/assistant/connect-to-bedrock.asciidoc * Formatting fix --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 61ee1ad)
* Creates new page detailing Bedrock connector setup * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * adds information about provisioned throughput * sentence edits * incorporates Charles' review * adds context to each section * adds video embeds * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * minor format fix * update heading * Update docs/assistant/connect-to-bedrock.asciidoc * Formatting fix --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 61ee1ad)
* Creates new page detailing Bedrock connector setup * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * adds information about provisioned throughput * sentence edits * incorporates Charles' review * adds context to each section * adds video embeds * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * minor format fix * update heading * Update docs/assistant/connect-to-bedrock.asciidoc * Formatting fix --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 61ee1ad) Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
* Creates new page detailing Bedrock connector setup * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/connect-to-bedrock.asciidoc Co-authored-by: Joe Peeples <[email protected]> * adds information about provisioned throughput * sentence edits * incorporates Charles' review * adds context to each section * adds video embeds * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * Update docs/assistant/connect-to-bedrock.asciidoc * minor format fix * update heading * Update docs/assistant/connect-to-bedrock.asciidoc * Formatting fix --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 61ee1ad) Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Fixes #5113 by adding a page with step by step details for how to set up an Amazon Bedrock connector.
Preview:Set up an Amazon Bedrock connector