Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates new page detailing Bedrock connector setup #5148

Merged
merged 18 commits into from
May 3, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Apr 30, 2024

Fixes #5113 by adding a page with step by step details for how to set up an Amazon Bedrock connector.

Preview:Set up an Amazon Bedrock connector

@benironside benironside added the Feature: Elastic AI Assistant Interface for interacting with generative AIs label Apr 30, 2024
@benironside benironside self-assigned this Apr 30, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 30, 2024

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@benironside benironside marked this pull request as ready for review April 30, 2024 21:19
@benironside benironside requested a review from a team as a code owner April 30, 2024 21:19
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few small line edits. Also, it'd help to give users a bit more context and explanation of what they're doing overall, and in each subsection. I think these steps are clear enough for users to follow, but we could tell them more about what they're doing, and why.

If Amazon changes their UI in the future (and of course they will), then our users will be better able to adjust if we equip them with a good understanding of broadly what they need to do. If they're just blindly following steps, it'll be harder for them to adjust.

docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
@benironside benironside requested review from Charelzard and removed request for elasticharles May 1, 2024 20:44
Copy link

@Charelzard Charelzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments I added, everything looks good. Please be sure to include the videos in each respective section. I like how you went the route to add the connectors vs doing it in the ai assistant to give a more standardized approach. We can use this in the other docs going forward.

docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
docs/assistant/connect-to-bedrock.asciidoc Outdated Show resolved Hide resolved
@benironside benironside requested a review from a team May 3, 2024 15:55
@benironside benironside added v8.13.0 v8.14.0 Priority: Urgent Issues that need to be resolved as soon as possible labels May 3, 2024
@mergify mergify bot removed the backport-skip label May 3, 2024
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The added bits nicely guide the reader through this multi-step process.

@benironside benironside merged commit 61ee1ad into main May 3, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 3, 2024
* Creates new page detailing Bedrock connector setup

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* adds information about provisioned throughput

* sentence edits

* incorporates Charles' review

* adds context to each section

* adds video embeds

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* minor format fix

* update heading

* Update docs/assistant/connect-to-bedrock.asciidoc

* Formatting fix

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 61ee1ad)
mergify bot pushed a commit that referenced this pull request May 3, 2024
* Creates new page detailing Bedrock connector setup

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* adds information about provisioned throughput

* sentence edits

* incorporates Charles' review

* adds context to each section

* adds video embeds

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* minor format fix

* update heading

* Update docs/assistant/connect-to-bedrock.asciidoc

* Formatting fix

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 61ee1ad)
benironside added a commit that referenced this pull request May 6, 2024
* Creates new page detailing Bedrock connector setup

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* adds information about provisioned throughput

* sentence edits

* incorporates Charles' review

* adds context to each section

* adds video embeds

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* minor format fix

* update heading

* Update docs/assistant/connect-to-bedrock.asciidoc

* Formatting fix

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 61ee1ad)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
benironside added a commit that referenced this pull request May 6, 2024
* Creates new page detailing Bedrock connector setup

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/connect-to-bedrock.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* adds information about provisioned throughput

* sentence edits

* incorporates Charles' review

* adds context to each section

* adds video embeds

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* Update docs/assistant/connect-to-bedrock.asciidoc

* minor format fix

* update heading

* Update docs/assistant/connect-to-bedrock.asciidoc

* Formatting fix

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 61ee1ad)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Elastic AI Assistant Interface for interacting with generative AIs Priority: Urgent Issues that need to be resolved as soon as possible v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]Connect Elastic AI Assistant to Amazon Bedrock
3 participants