-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request][ESS][8.14] ES|QL Timeline tab enabled by default and moved to GA #5139
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments. I also noticed that in all the screenshot of the Timeline modal, I see the Elastic AI Assistant
tab. This should not be visible anymore as the aiAssistantFlyoutMode
feature flag has been turned on by default a few days ago (and backported to the 8.14
branch, see here). The AI assisntant is now by default shown in a flyout, and we don't show the tab in Timeline anymore.
docs/advanced-entity-analytics/images/assign-asset-criticality-timeline.png
Show resolved
Hide resolved
Thanks for sharing this, @PhilippeOberti. I'm just now finding out about it, so I'll need to make one more update to the screenshots that I refreshed in this PR and the Serverless one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the screenshots, LGTM!
Only the first one (the Query tab showing old flyout) could be updated, but it seems that you guys will do that in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… moved to GA (backport #5139) (#5202) * Removing notes for tab and ES|QL * Removed tech preview note * Refreshed images * Updates gif * Re-added intro * First batch of re-refreshed images * Updated ES|QL tab image (cherry picked from commit 00589d8) Co-authored-by: Nastasha Solomon <[email protected]>
Addresses #5138 by updating content and screenshots in the "Investigate events in Timeline" page, and other various screenshots throughout the Security docset. Also contributes to #5149.
Preview: