Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][ESS][8.14] ES|QL Timeline tab enabled by default and moved to GA #5139

Merged
merged 11 commits into from
May 13, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Apr 30, 2024

Addresses #5138 by updating content and screenshots in the "Investigate events in Timeline" page, and other various screenshots throughout the Security docset. Also contributes to #5149.

Preview:

@nastasha-solomon nastasha-solomon added Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.14.0 Feature: ES|QL labels Apr 30, 2024
@nastasha-solomon nastasha-solomon self-assigned this Apr 30, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 7, 2024 19:18
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner May 7, 2024 19:18
Copy link

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments. I also noticed that in all the screenshot of the Timeline modal, I see the Elastic AI Assistant tab. This should not be visible anymore as the aiAssistantFlyoutMode feature flag has been turned on by default a few days ago (and backported to the 8.14 branch, see here). The AI assisntant is now by default shown in a flyout, and we don't show the tab in Timeline anymore.

@nastasha-solomon
Copy link
Contributor Author

I also noticed that in all the screenshot of the Timeline modal, I see the Elastic AI Assistant tab. This should not be visible anymore as the aiAssistantFlyoutMode feature flag has been turned on by default a few days ago (and backported to the 8.14 branch, see elastic/kibana#182633). The AI assisntant is now by default shown in a flyout, and we don't show the tab in Timeline anymore.

Thanks for sharing this, @PhilippeOberti. I'm just now finding out about it, so I'll need to make one more update to the screenshots that I refreshed in this PR and the Serverless one.

Copy link

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the screenshots, LGTM!

Only the first one (the Query tab showing old flyout) could be updated, but it seems that you guys will do that in a future PR

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit 00589d8 into main May 13, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 13, 2024
…to GA (#5139)

* Removing notes for tab and ES|QL

* Removed tech preview note

* Refreshed images

* Updates gif

* Re-added intro

* First batch of re-refreshed images

* Updated ES|QL tab image

(cherry picked from commit 00589d8)
nastasha-solomon added a commit that referenced this pull request May 13, 2024
… moved to GA (backport #5139) (#5202)

* Removing notes for tab and ES|QL

* Removed tech preview note

* Refreshed images

* Updates gif

* Re-added intro

* First batch of re-refreshed images

* Updated ES|QL tab image

(cherry picked from commit 00589d8)

Co-authored-by: Nastasha Solomon <[email protected]>
@nastasha-solomon nastasha-solomon deleted the issue-5138-esql-timeline-tab-ga branch May 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: ES|QL Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants