Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable setup guide field for custom rules [classic] #5091

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Editable setup guide field for custom rules [classic] #5091

merged 2 commits into from
Apr 16, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Apr 15, 2024 •
edited
Loading

@joepeeples joepeeples added enhancement New feature or request Team: Detections/Response Detections and Response Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.14.0 labels Apr 15, 2024
@joepeeples joepeeples self-assigned this Apr 15, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples mentioned this pull request Apr 15, 2024
Closed
@joepeeples joepeeples requested a review from dplumlee April 15, 2024 14:07
@joepeeples joepeeples marked this pull request as ready for review April 15, 2024 14:07
@joepeeples joepeeples requested a review from a team as a code owner April 15, 2024 14:07
jmikell821
jmikell821 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easiest PR review ever -- LGTM!

@joepeeples joepeeples merged commit d287528 into main Apr 16, 2024
3 checks passed
@joepeeples joepeeples deleted the 4917-setup-guide-rule-config branch April 16, 2024 14:28
@joepeeples joepeeples mentioned this pull request May 14, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

@dplumlee dplumlee dplumlee approved these changes

Assignees

@joepeeples joepeeples

Labels
Docset: ESS Issues that apply to docs in the Stack release enhancement New feature or request Feature: Rules Team: Detections/Response Detections and Response v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joepeeples @dplumlee @jmikell821 @nastasha-solomon