Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to global attributes and remove section-scoped pull and issue #4976

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Mar 22, 2024

Changes all instances of book/section-scoped attributes {pull} and {issue} to global attributes {kibana-pull} and {kibana-issue}, within the main branch.

Also removes the book/section-scoped definitions from the index file release-notes.asciidoc.

Note

We also made this change to the 7.17 branch with #4978. We didn't update any other currently available branches because they're unlikely to be part of the migration. When we migrate, we'll only be migrating main, 7.17, and whatever the current branch is at that time (probably 8.15 by that point, definitely not 8.13).

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Mar 22, 2024

This pull request does not have a backport label. Could you fix it @joepeeples? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@joepeeples joepeeples marked this pull request as ready for review March 25, 2024 13:42
@joepeeples joepeeples requested a review from a team as a code owner March 25, 2024 13:42
@joepeeples joepeeples changed the title [TEST] Switch to global attributes and remove section-scoped pull and issue Switch to global attributes and remove section-scoped pull and issue Mar 25, 2024
@joepeeples joepeeples mentioned this pull request Mar 25, 2024
jmikell821
jmikell821 previously approved these changes Mar 26, 2024
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this twice; LGTM :)

@natasha-moore-elastic natasha-moore-elastic merged commit aac845b into main Apr 2, 2024
3 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the test-swap-pull-attribute branch April 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants