Documents that nested fields aren't supported for Theshold rules "Group by" operations #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon.
Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
joepeeples
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
LGTM! I'm leaning away from adding a link to the nested fields docs. The concept seems easy to understand on its own, and that page gets real technical real fast, so it feels like extra homework for the reader instead of giving more clarity.
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
(cherry picked from commit fbc53b5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
(cherry picked from commit fbc53b5) # Conflicts: # docs/detections/rules-ui-create.asciidoc
benironside
added a commit
that referenced
this pull request
Jan 30, 2024
(cherry picked from commit fbc53b5) Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
benironside
added a commit
that referenced
this pull request
Jan 30, 2024
…es "Group by" operations (backport #4683) (#4694) * first pass, minor bugfix (#4683) (cherry picked from commit fbc53b5) # Conflicts: # docs/detections/rules-ui-create.asciidoc * fix merge conflict --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4119 by adding a note that says you can't use nested fields for "group by" to the doc about how to make a threshold rule.
Please let me know if you think we should add any other details. One thing we could consider adding a link to this page: https://www.elastic.co/guide/en/elasticsearch/reference/8.12/nested.html
Preview: Create a threshold rule