Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Endpoint Trusted Applications docs need to mention that process events will always be generated (Classic docs) #4640

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jan 18, 2024

Contributes to #3489 by updating the classic docs with additional explanation of how process events are still created for trusted applications.

Previews:

Twin PR for serverless docs

@joepeeples joepeeples added bug Something isn't working Feature: Elastic Defend Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Jan 18, 2024
@joepeeples joepeeples self-assigned this Jan 18, 2024
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@gabriellandau gabriellandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tweak/clarification.

docs/management/admin/trusted-apps.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@gabriellandau gabriellandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joepeeples joepeeples merged commit 00e913d into main Jan 24, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
… events will always be generated (Classic docs) (#4640)

* Add explanation to TA page, expand Optimize page

* Apply suggestions from code review

Co-authored-by: Gabriel Landau <[email protected]>

* Apply suggestions from code review

Co-authored-by: Gabriel Landau <[email protected]>

---------

Co-authored-by: Gabriel Landau <[email protected]>
(cherry picked from commit 00e913d)
@joepeeples joepeeples deleted the 3489-trusted-apps-process-events branch January 24, 2024 22:08
joepeeples added a commit that referenced this pull request Jan 24, 2024
… events will always be generated (Classic docs) (#4640) (#4672)

* Add explanation to TA page, expand Optimize page

* Apply suggestions from code review

Co-authored-by: Gabriel Landau <[email protected]>

* Apply suggestions from code review

Co-authored-by: Gabriel Landau <[email protected]>

---------

Co-authored-by: Gabriel Landau <[email protected]>
(cherry picked from commit 00e913d)

Co-authored-by: Joe Peeples <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Docset: ESS Issues that apply to docs in the Stack release Feature: Elastic Defend v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants