Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12][ESS] Document Osquery Timeout setting #4611

Merged
merged 10 commits into from
Jan 16, 2024
Merged

[8.12][ESS] Document Osquery Timeout setting #4611

merged 10 commits into from
Jan 16, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jan 12, 2024 •
edited by natasha-moore-elastic
Loading

@nastasha-solomon nastasha-solomon added Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management Feature: Osquery Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Jan 12, 2024
@nastasha-solomon nastasha-solomon self-assigned this Jan 12, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon linked an issue Jan 12, 2024 that may be closed by this pull request
[Request] Document Osquery Timeout setting #4536
Closed
13 tasks
@nastasha-solomon nastasha-solomon mentioned this pull request Jan 12, 2024
Closed
17 tasks
@nastasha-solomon nastasha-solomon marked this pull request as ready for review January 12, 2024 23:33
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner January 12, 2024 23:33
@natasha-moore-elastic natasha-moore-elastic mentioned this pull request Jan 15, 2024
Merged
@natasha-moore-elastic natasha-moore-elastic requested review from szwarckonrad and a team January 16, 2024 11:16
szwarckonrad
szwarckonrad previously approved these changes Jan 16, 2024
View reviewed changes
Copy link

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

benironside
benironside previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple optional suggestions

docs/osquery/osquery-response-action.asciidoc Show resolved Hide resolved
docs/osquery/invest-guide-run-osquery.asciidoc Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 7f0e5f2 into main Jan 16, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
@nastasha-solomon @mergify
[8.12][ESS] Document Osquery Timeout setting (#4611)
a067b21 
* First draft

* Update docs/osquery/alerts-run-osquery.asciidoc

* Update docs/osquery/invest-guide-run-osquery.asciidoc

* Update docs/osquery/invest-guide-run-osquery.asciidoc

* Update docs/osquery/osquery-response-action.asciidoc

* Aligning text with Natasa's descrip

* Adds timeout to response action fields

* Update docs/detections/api/rules/rules-api-create.asciidoc

* Ben's input

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 7f0e5f2)
@mergify mergify bot mentioned this pull request Jan 16, 2024
Merged
nastasha-solomon added a commit that referenced this pull request Jan 16, 2024
@mergify @nastasha-solomon
[8.12] [8.12][ESS] Document Osquery Timeout setting (backport #4611) (#…
2b69d7d 
…4618)

* First draft

* Update docs/osquery/alerts-run-osquery.asciidoc

* Update docs/osquery/invest-guide-run-osquery.asciidoc

* Update docs/osquery/invest-guide-run-osquery.asciidoc

* Update docs/osquery/osquery-response-action.asciidoc

* Aligning text with Natasa's descrip

* Adds timeout to response action fields

* Update docs/detections/api/rules/rules-api-create.asciidoc

* Ben's input

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 7f0e5f2)

Co-authored-by: Nastasha Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic left review comments

@benironside benironside benironside approved these changes

@szwarckonrad szwarckonrad szwarckonrad left review comments

Assignees

@nastasha-solomon nastasha-solomon

Labels
Docset: ESS Issues that apply to docs in the Stack release Effort: Small Issues that can be resolved quickly Feature: Osquery Priority: High Issues that are time-sensitive and/or are of high customer importance Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Document Osquery Timeout setting
4 participants
@nastasha-solomon @szwarckonrad @benironside @natasha-moore-elastic