Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional integration response actions (SentinelOne) — Classic docs #4593

Merged
merged 17 commits into from
Jan 17, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jan 10, 2024

Contributes to #4312 by adding high-level instructions on configuring SentinelOne's bidirectional response actions to the classic docs.

Preview: Response actions configuration

🚫 Dependency/Blocker

This PR includes a link (in Step 3) to the Connectors landing page in Kibana docs. This needs to be revised to a specific page for the SentinelOne connector docs, which won't exist until elastic/kibana#174696 is merged.

Update: We'll actually go ahead and merge this without revising the link to Kibana's connector docs. We can update it later once elastic/kibana#174696 is merged.

Twin PR for serverless docs

Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne)
@joepeeples joepeeples added Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management Feature: Response actions also includes response console Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Jan 10, 2024
@joepeeples joepeeples self-assigned this Jan 10, 2024
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

- Add link to S1 integration docs
- Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696)
@joepeeples
Copy link
Contributor Author

run docs-build

It breaks CI after all (at least it does in Buildkite)
@joepeeples joepeeples changed the title Bidirectional integration response actions (SentinelOne) — Classic Docs Bidirectional integration response actions (SentinelOne) — Classic docs Jan 11, 2024
@joepeeples joepeeples marked this pull request as ready for review January 11, 2024 20:14
@joepeeples joepeeples requested a review from a team as a code owner January 11, 2024 20:14
@joepeeples joepeeples mentioned this pull request Jan 12, 2024
17 tasks
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of minor suggestions.

docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: natasha-moore-elastic <[email protected]>
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joepeeples ,
I did a review in @patrykkopycinski 's absence and left some feedback.

docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
docs/management/admin/response-actions-config.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the changes. 👍

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joepeeples joepeeples merged commit 6793392 into main Jan 17, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
…cs (#4593)

* First draft

* Update Agent installation instructions

Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne)

* Add links to related docs

- Add link to S1 integration docs
- Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696)

* Fix broken link

It breaks CI after all (at least it does in Buildkite)

* Fix step numbering

* Add section heading syntax

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <[email protected]>

* Apply feedback: API tokens

* Reformat collapsible sections, a few edits

* Apply feedback: rule configuration

* Add details, clarification

- API token requirements
- Installing Agent

* Fix typo

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 6793392)
@joepeeples joepeeples deleted the 4312-sentinelone-response-action-classic branch January 17, 2024 21:37
joepeeples added a commit that referenced this pull request Jan 17, 2024
…cs (#4593) (#4622)

* First draft

* Update Agent installation instructions

Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne)

* Add links to related docs

- Add link to S1 integration docs
- Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696)

* Fix broken link

It breaks CI after all (at least it does in Buildkite)

* Fix step numbering

* Add section heading syntax

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <[email protected]>

* Apply feedback: API tokens

* Reformat collapsible sections, a few edits

* Apply feedback: rule configuration

* Add details, clarification

- API token requirements
- Installing Agent

* Fix typo

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
(cherry picked from commit 6793392)

Co-authored-by: Joe Peeples <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Response actions also includes response console Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants