-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidirectional integration response actions (SentinelOne) — Classic docs #4593
Conversation
Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne)
A documentation preview will be available soon.
Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
- Add link to S1 integration docs - Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696)
run docs-build |
It breaks CI after all (at least it does in Buildkite)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of minor suggestions.
Co-authored-by: natasha-moore-elastic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joepeeples ,
I did a review in @patrykkopycinski 's absence and left some feedback.
- API token requirements - Installing Agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the changes. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…cs (#4593) * First draft * Update Agent installation instructions Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne) * Add links to related docs - Add link to S1 integration docs - Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696) * Fix broken link It breaks CI after all (at least it does in Buildkite) * Fix step numbering * Add section heading syntax * Apply suggestions from Natasha's review Co-authored-by: natasha-moore-elastic <[email protected]> * Apply feedback: API tokens * Reformat collapsible sections, a few edits * Apply feedback: rule configuration * Add details, clarification - API token requirements - Installing Agent * Fix typo --------- Co-authored-by: natasha-moore-elastic <[email protected]> (cherry picked from commit 6793392)
…cs (#4593) (#4622) * First draft * Update Agent installation instructions Needed to make these slightly more generic, so we can reference them for installing Agent for other integrations (such as SentinelOne) * Add links to related docs - Add link to S1 integration docs - Add link to S1 connector docs, which will 404 (but not break build) until S1 connector docs are published (elastic/kibana#174696) * Fix broken link It breaks CI after all (at least it does in Buildkite) * Fix step numbering * Add section heading syntax * Apply suggestions from Natasha's review Co-authored-by: natasha-moore-elastic <[email protected]> * Apply feedback: API tokens * Reformat collapsible sections, a few edits * Apply feedback: rule configuration * Add details, clarification - API token requirements - Installing Agent * Fix typo --------- Co-authored-by: natasha-moore-elastic <[email protected]> (cherry picked from commit 6793392) Co-authored-by: Joe Peeples <[email protected]>
Contributes to #4312 by adding high-level instructions on configuring SentinelOne's bidirectional response actions to the classic docs.
Preview: Response actions configuration
🚫 Dependency/Blocker
This PR includes a link (in Step 3) to the Connectors landing page in Kibana docs. This needs to be revised to a specific page for the SentinelOne connector docs, which won't exist until elastic/kibana#174696 is merged.
Update: We'll actually go ahead and merge this without revising the link to Kibana's connector docs. We can update it later once elastic/kibana#174696 is merged.
Twin PR for serverless docs