Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes data type inconsitency in Apply alert tags API #4581

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fixes data type inconsitency in Apply alert tags API #4581

merged 1 commit into from
Jan 10, 2024

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Jan 9, 2024 •
edited
Loading

Fixes #4567 by updating the tags parameter's data type in the description to object.

Preview: Signals endpoint

@natasha-moore-elastic natasha-moore-elastic self-assigned this Jan 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review January 9, 2024 16:23
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner January 9, 2024 16:23
@natasha-moore-elastic natasha-moore-elastic mentioned this pull request Jan 9, 2024
Merged
dplumlee
dplumlee approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nastasha-solomon
nastasha-solomon reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - thanks @natasha-moore-elastic!

@dplumlee just to double-check, is the kibana.alert.workflow_tags alert field description correct here as well?

@dplumlee
Copy link
Contributor

@nastasha-solomon Yes, that's the field itself so it should just be a keyword array, we only use the object with tags_to_add and tags_to_remove in the API

@nastasha-solomon nastasha-solomon self-requested a review January 10, 2024 16:41
@natasha-moore-elastic natasha-moore-elastic merged commit 418ddf5 into main Jan 10, 2024
5 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-4567-tags-data-type branch January 10, 2024 16:55
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@natasha-moore-elastic @mergify
Fixes data type inconsitency in Apply alert tags API (#4581)
1cb4fcc 
(cherry picked from commit 418ddf5)
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@natasha-moore-elastic @mergify
Fixes data type inconsitency in Apply alert tags API (#4581)
9071733 
(cherry picked from commit 418ddf5)
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@natasha-moore-elastic @mergify
Fixes data type inconsitency in Apply alert tags API (#4581)
1a4066f 
(cherry picked from commit 418ddf5)
This was referenced Jan 10, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@natasha-moore-elastic @mergify
Fixes data type inconsitency in Apply alert tags API (#4581)
62f6fde 
(cherry picked from commit 418ddf5)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
natasha-moore-elastic added a commit that referenced this pull request Jan 10, 2024
@mergify @natasha-moore-elastic
Fixes data type inconsitency in Apply alert tags API (#4581) (#4584)
4556082 
(cherry picked from commit 418ddf5)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Jan 10, 2024
@mergify @natasha-moore-elastic
Fixes data type inconsitency in Apply alert tags API (#4581) (#4583)
e27c930 
(cherry picked from commit 418ddf5)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Jan 10, 2024
@mergify @natasha-moore-elastic
Fixes data type inconsitency in Apply alert tags API (#4581) (#4585)
11161cc 
(cherry picked from commit 418ddf5)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Jan 10, 2024
@mergify @natasha-moore-elastic
Fixes data type inconsitency in Apply alert tags API (#4581) (#4586)
27bbb48 
(cherry picked from commit 418ddf5)

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@dplumlee dplumlee dplumlee approved these changes

Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels
API bug Something isn't working Feature: Alerts Team: Detections/Response Detections and Response v8.9.0 v8.10.0 v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Data type inconsistency in 'Apply alert tags' API
3 participants
@natasha-moore-elastic @dplumlee @nastasha-solomon