Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents new Azure deployment methods for 8.12 #4551

Merged
merged 11 commits into from
Jan 16, 2024
Merged

Documents new Azure deployment methods for 8.12 #4551

merged 11 commits into from
Jan 16, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Jan 3, 2024 •
edited
Loading

Addresses part 3 of #4440 and fixes #4533 by documenting the new deployment methods for Azure in 8.12.

Preview: Get started with CSPM for Azure

@benironside benironside added Team: Cloud Security AWP + Cloud Security Posture Effort: Large Issues that require significant planning, research, writing, and testing Priority: Urgent Issues that need to be resolved as soon as possible v8.12.0 labels Jan 3, 2024
@benironside benironside self-assigned this Jan 3, 2024
@benironside benironside requested a review from a team as a code owner January 3, 2024 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

moukoublen
moukoublen previously approved these changes Jan 5, 2024
View reviewed changes
orestisfl
orestisfl previously approved these changes Jan 9, 2024
View reviewed changes
@tinnytintin10
Copy link
Contributor

@benironside In the requirements section, the third bullet reads

The user who gives the CSPM integration permissions must be an Azure subscription admin.

For the sake of clarity, let's change this instance and the one for GCP and AWS as well to read as follows:

"The user who gives the CSPM integration permissions in Azure must be an Azure subscription admin."

@benironside benironside mentioned this pull request Jan 15, 2024
Closed
17 tasks
@benironside benironside dismissed tinnytintin10’s stale review January 16, 2024 17:14

Incorporated requested changes

@benironside benironside dismissed stale reviews from orestisfl and moukoublen via fbb3d0d January 16, 2024 17:17
nastasha-solomon
nastasha-solomon previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some optional suggestions and a few corrections for super tiny typos.

docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-azure.asciidoc Outdated Show resolved Hide resolved
docs/cloud-native-security/cspm-get-started-gcp.asciidoc Show resolved Hide resolved
@benironside benironside requested a review from a team January 16, 2024 19:46
@benironside
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@nastasha-solomon
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@benironside benironside merged commit 2fe8fb9 into main Jan 16, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
@benironside @mergify
Documents new Azure deployment methods for 8.12 (#4551)
1302cc8 
* First complete draft - 8.12 Azure onboarding updates

* Minor changes to related docs for 8.12 Azure CSPM GA update

* minor updates

* minor update

* updates based on conversation with Kostas

* addresses Tinsae's feedback

* minor update

* incorporates Nastasha's review

(cherry picked from commit 2fe8fb9)
@mergify mergify bot mentioned this pull request Jan 16, 2024
Merged
benironside added a commit that referenced this pull request Jan 16, 2024
@mergify @benironside
Documents new Azure deployment methods for 8.12 (#4551) (#4615)
4c7f1ed 
* First complete draft - 8.12 Azure onboarding updates

* Minor changes to related docs for 8.12 Azure CSPM GA update

* minor updates

* minor update

* updates based on conversation with Kostas

* addresses Tinsae's feedback

* minor update

* incorporates Nastasha's review

(cherry picked from commit 2fe8fb9)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestisfl orestisfl orestisfl left review comments

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@tinnytintin10 tinnytintin10 tinnytintin10 left review comments

@moukoublen moukoublen moukoublen left review comments

Assignees

@benironside benironside

Labels
Effort: Large Issues that require significant planning, research, writing, and testing Priority: Urgent Issues that need to be resolved as soon as possible Team: Cloud Security AWP + Cloud Security Posture v8.12.0
Projects
Elastic Security Docs Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document CSPM Azure new onboarding options (GA)
5 participants
@benironside @tinnytintin10 @nastasha-solomon @moukoublen @orestisfl