Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-file-api.asciidoc to fix a typo #4500

Closed
wants to merge 1 commit into from

Conversation

nathandh22
Copy link

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nathandh22 nathandh22 closed this Dec 21, 2023
@nathandh22 nathandh22 reopened this Dec 21, 2023
@benironside benironside requested a review from a team December 21, 2023 18:38
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benironside benironside requested a review from a team December 21, 2023 18:39
@nathandh22
Copy link
Author

@benironside, one additional note I should have added earlier. The get-file typo exists in Elasticsearch 8.9+. I'm not sure how to push that change for all of these respective versions and forgot to bring it up when I filed this.

Would I just have to submit individual Commits/PRs for each and every version?

@natasha-moore-elastic
Copy link
Contributor

natasha-moore-elastic commented Dec 22, 2023

@benironside, one additional note I should have added earlier. The get-file typo exists in Elasticsearch 8.9+. I'm not sure how to push that change for all of these respective versions and forgot to bring it up when I filed this.

Would I just have to submit individual Commits/PRs for each and every version?

Hi @nathandh22 thanks for fixing this! Since this PR targets the elastic:8.11 branch, I will open another PR with these changes against the main branch. We can then add backporting labels to that new PR, which will automatically backport the changes to the needed versions.


Edit: I've now opened #4526 for these changes, so we can close this PR. Once #4526 is merged, the changes will be backported to all 8.9+ versions.

@natasha-moore-elastic
Copy link
Contributor

Closing this PR as the changes have been made in #4526.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants