-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get-file-api.asciidoc to fix a typo #4500
Conversation
According to the code (https://github.com/elastic/kibana/blob/6bec71021ac92a84da05a3646fe0992579c52832/x-pack/plugins/security_solution/common/endpoint/constants.ts#L94), it appears that the API endpoint should be `get_file`, not `get-file`. This corrects that typo.
A documentation preview will be available soon.
Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@benironside, one additional note I should have added earlier. The
Would I just have to submit individual Commits/PRs for each and every version? |
Hi @nathandh22 thanks for fixing this! Since this PR targets the Edit: I've now opened #4526 for these changes, so we can close this PR. Once #4526 is merged, the changes will be backported to all 8.9+ versions. |
Closing this PR as the changes have been made in #4526. |
According to the code (https://github.com/elastic/kibana/blob/6bec71021ac92a84da05a3646fe0992579c52832/x-pack/plugins/security_solution/common/endpoint/constants.ts#L94), it appears that the API endpoint should be
get_file
, notget-file
. This PR corrects the typo found in https://www.elastic.co/guide/en/security/8.11/get-file-api.html