Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold rule alert suppression [Classic] #4467

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Dec 13, 2023

Contributes to #4315 by updating classic docs to include support for suppressing threshold rule type alerts.

Previews

Twin PR

@joepeeples joepeeples added Feature: Rules Team: Detection Engine Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Dec 13, 2023
@joepeeples joepeeples self-assigned this Dec 13, 2023
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples marked this pull request as ready for review December 13, 2023 21:36
@joepeeples joepeeples requested a review from a team as a code owner December 13, 2023 21:36
@joepeeples joepeeples requested a review from vitaliidm December 13, 2023 21:36
docs/detections/alert-suppression.asciidoc Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @joepeeples

@joepeeples joepeeples changed the title Threshold rule alert suppression Threshold rule alert suppression [Classic] Dec 19, 2023
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joepeeples joepeeples merged commit f48ae9f into main Jan 3, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 3, 2024
* First draft for classic docs

* Revise language away from "matching"

More like "qualifying" or "meets the rule's criteria"

* Add option of empty "Group by"

* Edit word choice

(cherry picked from commit f48ae9f)
@joepeeples joepeeples deleted the 4315-threshold-alert-suppression branch January 3, 2024 19:59
joepeeples added a commit that referenced this pull request Jan 3, 2024
* First draft for classic docs

* Revise language away from "matching"

More like "qualifying" or "meets the rule's criteria"

* Add option of empty "Group by"

* Edit word choice

(cherry picked from commit f48ae9f)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples mentioned this pull request Jan 12, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Rules Team: Detection Engine v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants