Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt rule customization — JSON diff [Classic] #4463

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Dec 12, 2023

Contributes to #4371 by updating the classic docs with info on the JSON diff for prebuilt rule updates.

Preview: Install and manage Elastic prebuilt rules | Update Elastic prebuilt rules

Twin PR

@joepeeples joepeeples added Team: Detections/Response Detections and Response Feature: Rules Feature: Prebuilt rules Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Dec 12, 2023
@joepeeples joepeeples self-assigned this Dec 12, 2023
Copy link

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@joepeeples joepeeples changed the title Prebuilt rule customization — JSON diff Prebuilt rule customization — JSON diff [Classic] Dec 12, 2023
@joepeeples joepeeples marked this pull request as ready for review December 13, 2023 22:07
@joepeeples joepeeples requested a review from a team as a code owner December 13, 2023 22:07
nikitaindik
nikitaindik previously approved these changes Dec 14, 2023
Copy link
Contributor

@nikitaindik nikitaindik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the changes and the preview. LGTM. Thanks @joepeeples!

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples
Copy link
Contributor Author

Docs are approved, no further review or updates needed. OK to merge for classic docs.

@joepeeples joepeeples merged commit 42bd201 into main Dec 18, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 18, 2023
* First draft with prelim image

* Update screenshot

* Apply suggestions from Nikita's review

(cherry picked from commit 42bd201)
@joepeeples joepeeples deleted the 4371-json-diff-prebuilt-rules branch December 18, 2023 21:12
joepeeples added a commit that referenced this pull request Dec 18, 2023
* First draft with prelim image

* Update screenshot

* Apply suggestions from Nikita's review

(cherry picked from commit 42bd201)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples mentioned this pull request Jan 12, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Prebuilt rules Feature: Rules Team: Detections/Response Detections and Response v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants