Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new .yaml version of known issue template #4367

Merged
merged 9 commits into from
Dec 7, 2023
Merged

new .yaml version of known issue template #4367

merged 9 commits into from
Dec 7, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Dec 1, 2023 •
edited
Loading

Fixes #4356 by creating a .yaml version of the known issue template. In addition to converting from the old .md version, I made some changes to update it for the serverless era and some minor edits.

Preview: Known issue template

@benironside benironside self-assigned this Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Documentation previews:

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Dec 1, 2023
@benironside benironside marked this pull request as ready for review December 1, 2023 21:22
@benironside benironside requested a review from a team as a code owner December 1, 2023 21:22
nastasha-solomon
nastasha-solomon reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, just left one comment for your consideration. Thank you for making this! Hopefully it'll make our lives a bit easier when doc'ing known bugs : )

.github/ISSUE_TEMPLATE/known-issue.yaml Outdated Show resolved Hide resolved
jmikell821
jmikell821 reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these two nits are addressed, this will be good to go, thanks!

.github/ISSUE_TEMPLATE/known-issue.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/known-issue.yaml Outdated Show resolved Hide resolved
benironside and others added 2 commits December 6, 2023 15:16
jmikell821
jmikell821 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, thank you!

@benironside benironside merged commit a3777d3 into main Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon left review comments

@jmikell821 jmikell821 jmikell821 approved these changes

Assignees

@benironside benironside

Labels
backport-skip
Projects
Elastic Security Docs Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert known issue template to .yaml
3 participants
@benironside @jmikell821 @nastasha-solomon