Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the behavior of IM rules and multi-value indicator documents #4326

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Nov 29, 2023

Contributes to #3354.

Preview - inserted a note after step 2e

@nastasha-solomon nastasha-solomon added v8.2.0 v8.3.0 v8.4.0 v8.5.0 v8.6.0 v8.7.0 v8.8.0 v8.9.0 Team: Detection Engine Priority: Low Issues that need attention, but are not urgent v8.10.0 Effort: Medium Issues that take moderate but not substantial time to complete v8.11.0 labels Nov 29, 2023
@nastasha-solomon nastasha-solomon self-assigned this Nov 29, 2023
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review November 29, 2023 23:56
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner November 29, 2023 23:57
rylnd
rylnd previously approved these changes Nov 30, 2023
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are straightforward and LGTM!

docs/detections/rules-ui-create.asciidoc Show resolved Hide resolved
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nastasha-solomon nastasha-solomon merged commit ed4d816 into main Dec 6, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
…uments (backport #4326) (#4403)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 7, 2023
…uments (backport #4326) (#4405)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 7, 2023
…uments (backport #4326) (#4404)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…uments (backport #4326) (#4405)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…uments (backport #4326) (#4403)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Medium Issues that take moderate but not substantial time to complete Priority: Low Issues that need attention, but are not urgent Team: Detection Engine v8.2.0 v8.3.0 v8.4.0 v8.5.0 v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants