Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds enhancement request github issue template #4318

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Adds enhancement request github issue template #4318

merged 11 commits into from
Dec 1, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Nov 28, 2023 •
edited
Loading

Fixes #4311 by creating a new GH issue template for enhancement requests.

Preview

@benironside benironside self-assigned this Nov 28, 2023
@github-actions GitHub Actions
Copy link

Documentation previews:

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2023

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@benironside benironside marked this pull request as ready for review November 29, 2023 19:19
@benironside benironside requested a review from a team as a code owner November 29, 2023 19:19
joepeeples
joepeeples reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one word-choice suggestion, but it'd probably be good to get at least one more review from the team so I'll leave it to them to approve. Thanks for creating these templates!

.github/ISSUE_TEMPLATE/enhancement-request.yaml Outdated Show resolved Hide resolved
@benironside benironside requested a review from a team November 29, 2023 20:04
jmikell821
jmikell821 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions. Thanks for pulling this together!

.github/ISSUE_TEMPLATE/enhancement-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement-request.yaml Show resolved Hide resolved
jmikell821
jmikell821 previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small nit, then good to merge!

jmikell821
jmikell821 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can always tweak it later if needed. Thanks!

@benironside benironside merged commit fc2f956 into main Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

Assignees

@benironside benironside

Labels
backport-skip
Projects
Elastic Security Docs Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new Issue template for documentation enhancement requests
3 participants
@benironside @jmikell821 @joepeeples