Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Analytics: Requirements and limitations #4162

Merged
merged 14 commits into from
Nov 7, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Nov 1, 2023

Resolves #4124.

Adds a new page within Elastic Security requirements that outlines user requirements and known limitations of the new risk scoring engine.

Preview: Entity Analytics prerequisites

@natasha-moore-elastic natasha-moore-elastic added Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Medium Issues that take moderate but not substantial time to complete v8.11.0 Docset: ESS Issues that apply to docs in the Stack release Team: Entity Analytics labels Nov 1, 2023
@natasha-moore-elastic natasha-moore-elastic self-assigned this Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Documentation previews:

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review November 1, 2023 18:14
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great! I left a few suggestions and questions below. Hopefully they're helpful. 😄

@@ -0,0 +1,37 @@
[[ea-requirements]]
= Entity Analytics prerequisites

Copy link
Contributor

@nastasha-solomon nastasha-solomon Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natasha-moore-elastic following the page title with a section header is a bit jarring. To give users some quick context, it might be useful to write a sentence or two that briefly summarizes this page.

@SourinPaul are we now calling the risk scoring feature "Entity Analytics" in the docs? Also, should this page be included under the Useful links section within the Entity Risk Score page? Linking to multiple doc pages in the UI is a little excessive imo, but I definitely think feature requirements are necessary to highlight.

Screenshot 2023-11-01 at 2 46 47 PM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SourinPaul are we now calling the risk scoring feature "Entity Analytics" in the docs? Also, should this page be included under the Useful links section within the Entity Risk Score page? Linking to multiple doc pages in the UI is a little excessive imo, but I definitely think feature requirements are necessary to highlight.

@nastasha-solomon the current UI reference to the feature is incorrect. Here is the bug logged to correct the UI reference #7920. In its correct form, the UI reference will take the user to the (new) Entity Risk Scoring feature documentation page.

I agree that linking to multiple doc pages (Feature overview, Prerequisites for the feature) in the UI may be excessive, given we expect to improve or evolve the feature quickly.

How about ensuring the Entity Risk Scoring Prerequisites section is highlighted on the page the user first lands ( section above)?

Copy link
Contributor

@nastasha-solomon nastasha-solomon Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing that issue, @SourinPaul. Good to know that the links are being updated for 8.11! :)

As for linking this page, I do think it should be placed at the top of the list under the Useful links section. I'd use the page title as well, so the linked text is consistent with our docs.

Lastly, it might be a good idea to reference this page wherever these privileges are needed to view risk score data within the Security app. For example, if these privileges are required to turn on and or view risk score in the Entity Analytics dashboard, I would mention it there. I'm not sure what that'd look like, or if there's even time to add it into 8.11, so just something to consider for a future release.

docs/getting-started/ea-req.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/ea-req.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/ea-req.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/ea-req.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/ea-req.asciidoc Outdated Show resolved Hide resolved
@natasha-moore-elastic
Copy link
Contributor Author

Thanks for the fast reviews @nastasha-solomon & @SourinPaul! I've applied the suggestions and comments.

@natasha-moore-elastic
Copy link
Contributor Author

The build has failed because of the reference to the <<entity-risk-scoring, Entity Risk Scoring>> section, which isn't in main yet. Once PR #4167 is merged, the build should pass.

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, and one general question: what's the preferred capitalization for this feature? Sometimes it appears title case, other times lowercase. I personally prefer lowercase for most features, but it depends on how Product is positioning and branding this.

docs/getting-started/ers-req.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/ers-req.asciidoc Outdated Show resolved Hide resolved
@natasha-moore-elastic
Copy link
Contributor Author

A couple of small comments, and one general question: what's the preferred capitalization for this feature? Sometimes it appears title case, other times lowercase. I personally prefer lowercase for most features, but it depends on how Product is positioning and branding this.

Good question! @SourinPaul, is there a preference to capitalize the feature name from the Product side? If not, let's lowercase it, per our capitalization guidelines.

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add; previous feedback looks good.

@natasha-moore-elastic natasha-moore-elastic merged commit aad7b27 into main Nov 7, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 7, 2023
* Entity Analytics: Requirements and limitations

* Fixes capitalization

* Uses attribute

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Applies review comments

* Adds reference to Entity Risk Scoring

* Updates licensing info

* Applies review feedback

* Update docs/getting-started/ers-req.asciidoc

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit aad7b27)
@natasha-moore-elastic natasha-moore-elastic deleted the issue-4124-EA-reqs branch November 7, 2023 13:29
natasha-moore-elastic added a commit that referenced this pull request Nov 7, 2023
* Entity Analytics: Requirements and limitations

* Fixes capitalization

* Uses attribute

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Update docs/getting-started/ea-req.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Applies review comments

* Adds reference to Entity Risk Scoring

* Updates licensing info

* Applies review feedback

* Update docs/getting-started/ers-req.asciidoc

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit aad7b27)

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Effort: Medium Issues that take moderate but not substantial time to complete Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Entity Analytics v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity Analytics configurations and permissions
6 participants