Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] CSPM onboarding for Azure (subscription-level) and for GCP (organization-level) #4111

Merged
merged 29 commits into from
Nov 7, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Oct 27, 2023

Addresses #3774 (twin serverless PR also needed) by adding an Azure deployment guide for CSPM and updating the GCP deployment guide for CSPM to include organization-level onboarding.

Previews:
Get started with Azure
Get started with GCP

@benironside benironside added Team: Cloud Security AWP + Cloud Security Posture v8.11.0 labels Oct 27, 2023
@benironside benironside self-assigned this Oct 27, 2023
@github-actions
Copy link

Documentation previews:

Copy link
Contributor

mergify bot commented Nov 3, 2023

This pull request is now in conflicts. Could you fix it @benironside? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 3774-8.11-CSPM-AzureSingle-GCPMulti upstream/3774-8.11-CSPM-AzureSingle-GCPMulti
git merge upstream/main
git push upstream 3774-8.11-CSPM-AzureSingle-GCPMulti

Copy link
Contributor

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure LGTM but since parts of it are based on my notes, I would suggest for more people to take a look.

@benironside benironside mentioned this pull request Nov 3, 2023
15 tasks
@benironside benironside requested a review from a team November 5, 2023 23:18
@joepeeples
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@joepeeples
Copy link
Contributor

CI appeared to be stuck, so I tried restarting it...

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, otherwise LGTM!

@benironside benironside merged commit c474501 into main Nov 7, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Nov 7, 2023
…ganization-level) (#4111)

* saving work

* preliminary draft

* fixes build errors

* Incorporates new information received today for Azure and GCP

* formatting fix for azure

* add missing punctuation

* minor update

* adjust internal ToC

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Amir Ben Nun <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Amir Ben Nun <[email protected]>

* incorporate feedback

* incorporates feedback

* minor formatting fix

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

* setup -> set up

* incorporates Joe's feedback

* typo fix

* minor fix

---------

Co-authored-by: Orestis Floros <[email protected]>
Co-authored-by: Amir Ben Nun <[email protected]>
(cherry picked from commit c474501)
benironside added a commit that referenced this pull request Nov 7, 2023
…ganization-level) (#4111) (#4203)

* saving work

* preliminary draft

* fixes build errors

* Incorporates new information received today for Azure and GCP

* formatting fix for azure

* add missing punctuation

* minor update

* adjust internal ToC

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-azure.asciidoc

Co-authored-by: Orestis Floros <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Amir Ben Nun <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Amir Ben Nun <[email protected]>

* incorporate feedback

* incorporates feedback

* minor formatting fix

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

* setup -> set up

* incorporates Joe's feedback

* typo fix

* minor fix

---------

Co-authored-by: Orestis Floros <[email protected]>
Co-authored-by: Amir Ben Nun <[email protected]>
(cherry picked from commit c474501)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Cloud Security AWP + Cloud Security Posture v8.11.0
Projects
Development

Successfully merging this pull request may close these issues.

4 participants