Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates warning about editing rules using API authentication #4110

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Oct 27, 2023

@natasha-moore-elastic natasha-moore-elastic added Team: Detections/Response Detections and Response API Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Effort: Small Issues that can be resolved quickly v8.11.0 labels Oct 27, 2023
@natasha-moore-elastic natasha-moore-elastic self-assigned this Oct 27, 2023
@github-actions
Copy link

Documentation previews:

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions. If you incorporate the "will be" -> "gets" suggestion, it applies to the other WARNING messages as well. Thanks!

docs/detections/api/rules/rules-api-overview.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-update.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon self-requested a review October 31, 2023 12:31
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…4150)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…4151)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…4152)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4153)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4154)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4155)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4156)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4158)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4157)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4159)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4160)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc

* Resolves conflict

* Removes deprecation note

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 1, 2023
…ackport #4110) (#4161)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 783ce5a)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…ackport #4110) (#4158)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 0c55d76)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…ackport #4110) (#4161)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 0c55d76)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/api/rules/rules-api-create.asciidoc
#	docs/detections/api/rules/rules-api-import.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…ackport #4110) (#4154)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 0c55d76)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
…ackport #4110) (#4155)

* Updates warning about editing rules using API authentication (#4110)

* Updates warning about editing rules using API authentication

* Apply suggestions from TW review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Applies TW feedback

* Updates notes to address both scenarios

* Removes extra period

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 0c55d76)

# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc

* Resolves conflict

* Removes frontmatter

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rules management] updating rule through API key
5 participants