Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] Data Quality dashboard Same Family updates #4107

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Oct 26, 2023

Fixes #4026 by updating the data quality dashboard page screenshots to include the "Same family" work completed in 8.11, and adds a note linking to a related documentation page that gives more info about the same family classification.

Andrew, please check if the note about the same family category seems completely accurate to you. Thanks!

Preview: Data quality dashboard 8.11

Note: these changes are not yet present in serverless

@github-actions
Copy link

Documentation previews:

Copy link

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @benironside!
LGTM 🚀

@benironside benironside requested a review from a team October 27, 2023 15:12
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla tiny nits, looks good!

docs/dashboards/data-quality-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/data-quality-dashboard.asciidoc Outdated Show resolved Hide resolved
@benironside benironside requested a review from a team October 27, 2023 16:07
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benironside benironside merged commit ce43b36 into main Oct 27, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Oct 27, 2023
* DQ dashboard Same Family updates

* Incorporates Andrew's feedback

* Update docs/dashboards/data-quality-dashboard.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/dashboards/data-quality-dashboard.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit ce43b36)
benironside added a commit that referenced this pull request Oct 27, 2023
* DQ dashboard Same Family updates

* Incorporates Andrew's feedback

* Update docs/dashboards/data-quality-dashboard.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/dashboards/data-quality-dashboard.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit ce43b36)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Separate 'Same Family' Classification in Data Quality Dashboard
4 participants