Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs][Rules] Remove custom highlighted fields params from Rule Creation API Docs in 8.10 #4085

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[Docs][Rules] Remove custom highlighted fields params from Rule Creation API Docs in 8.10 #4085

merged 1 commit into from
Oct 25, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 23, 2023 •
edited
Loading

Fixes #4082.

Preview - Removed the investigation_fields parameter from the Create rule API docs.

@nastasha-solomon nastasha-solomon self-assigned this Oct 23, 2023
@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 23, 2023 20:36
@nastasha-solomon nastasha-solomon requested review from yctercero and a team October 23, 2023 20:36
@nastasha-solomon nastasha-solomon mentioned this pull request Oct 23, 2023
Closed
yctercero
yctercero approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks so much!

Just a note, when we add it back in for 8.11 - it'll need to be a string array for field_names. Apologies that I missed that initially.

@nastasha-solomon nastasha-solomon mentioned this pull request Oct 23, 2023
Closed
@nastasha-solomon
Copy link
Contributor Author

All good, @yctercero! I filed the following to track the updates to the field_names type:

@nastasha-solomon nastasha-solomon merged commit ab78fda into 8.10 Oct 25, 2023
2 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-4082-remove-invest-field branch October 25, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic approved these changes

@yctercero yctercero yctercero approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Team: Detection Engine v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nastasha-solomon @yctercero @natasha-moore-elastic