-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine] update lists API #4067
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for making these changes, @vitaliidm! Looks good overall, just a few questions (GH won't let me comment on the specific lines):
-
In
lists-index-api-overview.asciidoc
, should we update the following ’index’ / ‘indices’ references?- line 40: "Get index"
- line 81: "Example response when the indices do not exist"
-
In
detections-req.asciidoc
, should we add “and data streams” on the following lines?- line 74: "The
manage
,write
,read
, andview_index_metadata
index privileges for the following system indices" - line 99: "The
manage
,write
,read
, andview_index_metadata
index privileges for the following system indices, where<space-id>
is the {kib} space name" - line 121: "The
maintenance
,write
,read
, andview_index_metadata
index privileges for the following system indices, where<space-id>
is the {kib} space name"
- line 74: "The
-
If the endpoint itself is still
api/lists/index
, I’m wondering if we should keep thelists-index-api-overview.html
page title as Lists index endpoint, to avoid confusion?
@natasha-moore-elastic I have updated first 2 points. |
I agree, @natasha-moore-elastic. Another reason to keep the title as it is: Also, I'm not sure where this UI text is stored, but I think we also need to update the banner that appears on the Alerts page if users don't have certain privs. This is what I'm talking about, @vitaliidm: |
@nastasha-solomon , changed back list index endpoint Here is draft PR: elastic/kibana#169916 |
@vitaliidm can you elaborate on this:
I'm mainly suggesting that we update the text in the Insufficient privileges banner so that it aligns with the changes you made here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go!
* update lists API * fix typo * updates * more changes * updates * remove /index mention * CR * Update lists-index-api-overview.asciidoc --------- Co-authored-by: Nastasha Solomon <[email protected]> Co-authored-by: natasha-moore-elastic <[email protected]> (cherry picked from commit 7db2b5b)
Co-authored-by: Nastasha Solomon <[email protected]> Co-authored-by: natasha-moore-elastic <[email protected]> Co-authored-by: Vitalii Dmyterko <[email protected]>
Fixes #4069
updates list API description with data stream mentions