-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates data views gif #4053
Merged
Merged
Updates data views gif #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha-moore-elastic
added
bug
Something isn't working
Feature: Data Views
Team: Detection Engine
Priority: Medium
Issues that have relevance, but aren't urgent
Effort: Small
Issues that can be resolved quickly
v8.11.0
labels
Oct 17, 2023
Documentation previews: |
benironside
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
I like this approach to single sourcing for serverless/classic by cutting out some context in the gif to focus on the most important part.
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Updates data views gif * Updates gif (cherry picked from commit 860710c)
natasha-moore-elastic
added a commit
that referenced
this pull request
Oct 25, 2023
* Updates data views gif * Updates gif (cherry picked from commit 860710c) Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Effort: Small
Issues that can be resolved quickly
Feature: Data Views
Priority: Medium
Issues that have relevance, but aren't urgent
Team: Detection Engine
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #4002:
dataview-filter-example.gif
to make it platform-agnostic, so it can be single-sourced for ServerlessRelated Serverless PRs:
Preview: Data views in Elastic Security