Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates data views gif #4053

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Updates data views gif #4053

merged 3 commits into from
Oct 23, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Oct 17, 2023

Resolves part of #4002:

  • Updates dataview-filter-example.gif to make it platform-agnostic, so it can be single-sourced for Serverless
  • Updates Advanced settings to Advanced options

Related Serverless PRs:

Preview: Data views in Elastic Security

@natasha-moore-elastic natasha-moore-elastic added bug Something isn't working Feature: Data Views Team: Detection Engine Priority: Medium Issues that have relevance, but aren't urgent Effort: Small Issues that can be resolved quickly v8.11.0 labels Oct 17, 2023
@natasha-moore-elastic natasha-moore-elastic self-assigned this Oct 17, 2023
@github-actions
Copy link

Documentation previews:

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review October 17, 2023 11:07
@natasha-moore-elastic natasha-moore-elastic requested a review from a team October 17, 2023 11:07
@natasha-moore-elastic natasha-moore-elastic linked an issue Oct 17, 2023 that may be closed by this pull request
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
I like this approach to single sourcing for serverless/classic by cutting out some context in the gif to focus on the most important part.

@natasha-moore-elastic natasha-moore-elastic merged commit 860710c into main Oct 23, 2023
1 check passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-4002-data-views branch October 23, 2023 10:37
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
* Updates data views gif

* Updates gif

(cherry picked from commit 860710c)
natasha-moore-elastic added a commit that referenced this pull request Oct 25, 2023
* Updates data views gif

* Updates gif

(cherry picked from commit 860710c)

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Effort: Small Issues that can be resolved quickly Feature: Data Views Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Data views - screenshot & terminology updates
2 participants