Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ML page with anomaly detection jobs from Elastic integrations #3648

Merged
merged 17 commits into from
Aug 9, 2023
Merged

Update ML page with anomaly detection jobs from Elastic integrations #3648

merged 17 commits into from
Aug 9, 2023

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c commented Jul 27, 2023 •
edited
Loading

@github-actions
Copy link

Documentation previews:

@susan-shu-c susan-shu-c changed the title Update ML page with anomaly detection jobs from Elastic integrations [WIP] Update ML page with anomaly detection jobs from Elastic integrations Jul 27, 2023
@mergify
Copy link

mergify bot commented Jul 27, 2023

This pull request does not have a backport label. Could you fix it @susan-shu-c? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@susan-shu-c susan-shu-c marked this pull request as ready for review August 2, 2023 15:16
@susan-shu-c susan-shu-c changed the title [WIP] Update ML page with anomaly detection jobs from Elastic integrations Update ML page with anomaly detection jobs from Elastic integrations Aug 2, 2023
@susan-shu-c susan-shu-c mentioned this pull request Aug 2, 2023
Closed
@susan-shu-c susan-shu-c mentioned this pull request Aug 3, 2023
Merged
jmikell821
jmikell821 reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, thanks!

docs/detections/machine-learning/machine-learning.asciidoc Outdated Show resolved Hide resolved
docs/detections/machine-learning/machine-learning.asciidoc Outdated Show resolved Hide resolved
benironside
benironside reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion

@susan-shu-c
Copy link
Member Author

Thank you @jmikell821 and @benironside !

There's an accompanying PR to go out with this one in stack-docs:

Also, as discussed with @jmikell821 I will also remove the sub-section link in 16cb5f6 before merging

@jmikell821 jmikell821 merged commit 27cd7fe into main Aug 9, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Aug 9, 2023
@susan-shu-c @mergify
Update ML page with anomaly detection jobs from Elastic integrations (#…
2e1a762 
…3648)

* ML page - update subsection

* Update wording, test linking internal ref

* Update broken link

* Add url subsection

* PR review

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Remove subsection in url breaking the build

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Update capitalization

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Capitalization

---------

Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 27cd7fe)
@mergify mergify bot mentioned this pull request Aug 9, 2023
Merged
jmikell821 pushed a commit that referenced this pull request Aug 9, 2023
@mergify @susan-shu-c
Update ML page with anomaly detection jobs from Elastic integrations (#…
25401bf 
…3648) (#3706)

* ML page - update subsection

* Update wording, test linking internal ref

* Update broken link

* Add url subsection

* PR review

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Remove subsection in url breaking the build

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Update capitalization

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Capitalization

---------

Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 27cd7fe)

Co-authored-by: Susan <[email protected]>
@jmikell821 jmikell821 mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajosh0504 ajosh0504 ajosh0504 left review comments

@jmikell821 jmikell821 jmikell821 left review comments

@benironside benironside benironside left review comments

@sodhikirti07 sodhikirti07 sodhikirti07 approved these changes

Assignees
No one assigned
Labels
Feature: Machine Learning v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susan-shu-c @ajosh0504 @jmikell821 @benironside @sodhikirti07