Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates around truncated error messages on execution logs #3577

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Updates around truncated error messages on execution logs #3577

merged 3 commits into from
Jul 19, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Jul 18, 2023 •
edited
Loading

Resolves #3172.

Preview:

@natasha-moore-elastic natasha-moore-elastic added Team: Detections/Response Detections and Response Feature: Rules v8.9.0 v8.8.1 Priority: Low Issues that need attention, but are not urgent Effort: Small Issues that can be resolved quickly labels Jul 18, 2023
@natasha-moore-elastic natasha-moore-elastic requested a review from a team July 18, 2023 11:47
@natasha-moore-elastic natasha-moore-elastic self-assigned this Jul 18, 2023
@github-actions
Copy link

Documentation previews:

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review July 18, 2023 17:14
@joepeeples joepeeples self-requested a review July 18, 2023 17:15
joepeeples
joepeeples approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added an optional suggestion for editing.

docs/detections/rules-ui-monitor.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples requested a review from a team July 18, 2023 19:13
@natasha-moore-elastic natasha-moore-elastic merged commit 811c193 into main Jul 19, 2023
1 check passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-3172-truncated-errors branch July 19, 2023 09:34
mergify bot pushed a commit that referenced this pull request Jul 19, 2023
@natasha-moore-elastic @mergify
Updates around truncated error messages on execution logs (#3577)
2525c91 
* Updates around truncated error messages on execution logs

* Update docs/detections/rules-ui-monitor.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 811c193)
@mergify mergify bot mentioned this pull request Jul 19, 2023
Merged
natasha-moore-elastic added a commit that referenced this pull request Jul 19, 2023
@mergify @natasha-moore-elastic
Updates around truncated error messages on execution logs (#3577) (#3595
ab42988 
)

* Updates around truncated error messages on execution logs

* Update docs/detections/rules-ui-monitor.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 811c193)

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@joepeeples joepeeples joepeeples approved these changes

Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Low Issues that need attention, but are not urgent Team: Detections/Response Detections and Response v8.8.1 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truncated error messages on rule details, execution results
3 participants
@natasha-moore-elastic @nastasha-solomon @joepeeples