Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updated for unmapped fields and fields with type conflicts #3574

Merged
merged 12 commits into from
Jul 27, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 17, 2023

Fixes #3527.

Previews:

@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review July 17, 2023 20:58
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Left one small comment.

docs/detections/add-exceptions.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon requested a review from a team July 18, 2023 20:47
@nastasha-solomon nastasha-solomon requested a review from a team July 23, 2023 19:38
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit 568f369 into main Jul 27, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Jul 27, 2023
nastasha-solomon added a commit that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI updated for unmapped fields and fields with type conflicts
4 participants